Parse without use of regex to work around dependency conflict #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependencies of the `regex` crate (especially `memchr`) clash with my runtime dependencies which need to be `no_std`. I don't think there's a general way to prevent feature clashes between build-time and run-time dependencies yet. So the most straightforward workaround seems to be to write the parsing in this crate without relying on a regex.
|
@ilya-epifanov are there any plans to accept this one? It seems pretty clear that depending on std libraries isn't really portable for something so low level |
|
please try running cargo with |
|
Thanks, yes, haven't tried yet (I'm not currently actively working on this project) but agree that solving the underlying issue is a better long-run solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies of the
regexcrate (especiallymemchr) clash with my runtime dependencies which need to beno_std. I don't think there's a general way to prevent feature clashes between build-time and run-time dependencies yet.So the most straightforward workaround seems to be to write the parsing in this crate without relying on a regex. It hardly increases the length or complexity of the code.