Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nullable/x-nullable #302

Merged
merged 4 commits into from
Sep 13, 2020

Conversation

kbedel
Copy link
Contributor

@kbedel kbedel commented Dec 13, 2019

Fixes #300

Currently these properties are always going to be written. If you think this could cause issues, I can add support for it being behind a flag.

@kbedel
Copy link
Contributor Author

kbedel commented Aug 26, 2020

@kailuowang Would it be possible to get this merged? I can also create an equivalent PR for Play 2.8 if you like

@kailuowang
Copy link
Member

@kbedel sorry I lost track of this one. I am not sure that you need an extra field in all those places. Is it not possible to just use the required field? I mean if it's not required you add an x-nullable property?

@kbedel
Copy link
Contributor Author

kbedel commented Aug 26, 2020

OpenAPI Generator requires the x-nullable attribute to properly generate the C# client code we are using (the issue has links to their doc and a closed issue from that side)

@kbedel
Copy link
Contributor Author

kbedel commented Sep 11, 2020

@kailuowang Do you also need a play 2.8 version in order for this to get merged? We currently are relying on a forked version but I'd like to move back to the mainline as we move to Play 2.8

@kailuowang
Copy link
Member

@kbedel yes if you don't mind please create a separate PR to the 2.8 branch. I'll merge both and release.

@kailuowang kailuowang changed the base branch from play2.7 to master September 11, 2020 21:48
@kailuowang kailuowang merged commit 010757e into iheartradio:master Sep 13, 2020
@kbedel kbedel deleted the x-nullable_play27 branch September 14, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add x-nullable: true for Option[T]
2 participants