Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular Progress Indicator does not support RTL #5903

Closed
simeonoff opened this issue Oct 2, 2019 · 0 comments · Fixed by #6486
Closed

Circular Progress Indicator does not support RTL #5903

simeonoff opened this issue Oct 2, 2019 · 0 comments · Fixed by #6486
Assignees
@Aleksandyr @zdrawku
Labels
circular-progress RTL Support 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@simeonoff
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The circular progress indicator doesn't have right-to-left support.

Describe the solution you'd like

I would like to have right-to-left support.
@radomirchev radomirchev mentioned this issue Oct 2, 2019
Closed
@Aleksandyr Aleksandyr added the 🛠️ status: in-development Issues and PRs with active development on them label Jan 14, 2020
Aleksandyr added a commit that referenced this issue Jan 16, 2020
@Aleksandyr
feat(bidir service): provide bidir global service and fix circbar rtl
15a4826 
Closes #5903
@Aleksandyr Aleksandyr mentioned this issue Jan 16, 2020
Merged
14 tasks
@Aleksandyr Aleksandyr added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 16, 2020
Aleksandyr added a commit that referenced this issue Jan 17, 2020
@Aleksandyr
chore(changelog): add directionality service
9b309de 
Closes #5903
Aleksandyr added a commit that referenced this issue Jan 22, 2020
@Aleksandyr
fix(progressbar): fix lint errors in directionality spec
bef777a 
Closes #5903
Aleksandyr added a commit that referenced this issue Jan 22, 2020
@Aleksandyr
fix(bidir): remove the service from public api file
fde7598 
Closes #5903
Aleksandyr added a commit that referenced this issue Jan 22, 2020
@Aleksandyr
fix(directionality): rename the service
7e5011c 
Closes #5903
Aleksandyr added a commit that referenced this issue Jan 23, 2020
@Aleksandyr
fix(progressbar): applying latest review changes
7fdf075 
Closes #5903
Aleksandyr added a commit that referenced this issue Jan 24, 2020
@Aleksandyr
fix(bidir): expose getter for rtl check
7e87f5e 
Closes #5903
Aleksandyr added a commit that referenced this issue Jan 24, 2020
@Aleksandyr
fix(bidir): fix lint errors
d264e7b 
Closes #5903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aleksandyr Aleksandyr

@zdrawku zdrawku

Labels
circular-progress RTL Support 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bidir service): provide bidir global service and fix circbar rtl IgniteUI/igniteui-angular
3 participants
@simeonoff @Aleksandyr @zdrawku