Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Support #5791

Closed
zdrawku opened this issue Sep 12, 2019 · 3 comments · Fixed by #5976
Closed

RTL Support #5791

zdrawku opened this issue Sep 12, 2019 · 3 comments · Fixed by #5976
Assignees
Labels
grid: general RTL Support 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@zdrawku
Copy link
Contributor

zdrawku commented Sep 12, 2019

Is your feature request related to a problem? Please describe.

Right-to-left language support is not working properly in most of the components

Components list

https://github.com/IgniteUI/igniteui-angular#current-list-of-components-include

Component Problem Assignee Fixed?
Banner styling @desig9stein
Chip styling @simeonoff
Calendar styling @simeonoff
Card styling @simeonoff
Card Sample styling @simeonoff
Carousel styling @simeonoff
Combo styling @desig9stein
Input Group styling @simeonoff
Dialog styling @desig9stein
Expansion Panel styling @desig9stein
Switch styling @simeonoff
Snackbar styling @simeonoff
Radio styling @simeonoff
Checkbox styling @simeonoff
List styling @desig9stein
Navbar styling @simeonoff
Progress Indicators styling @simeonoff ⚠️ *
Navdrawer styling @desig9stein
Slider Typescript / Styling @desig9stein ⚠️ *
Tabs Typescript ? ⚠️ *
Date Picker styling @simeonoff
Time Picker styling @desig9stein
Grid Typescript / Styling ? ⚠️ *

* Styling done. Requires additional Typescript modification to get some elements fully working.

Describe the solution you'd like

The components should provide right-to-left visual alignment and actions of its content and related elements.

Note: Currently, the Grid provides a visual representation of the RTL alignment, although there is additional work that should be done in order to improve it.

@ItielBeeri
Copy link

Thanks, this is a must-have feature for millions of users.
Since this issue arose from my post in the forums, I would like to emphasize that this requirement isn't limited to the grid component, but is a cross-cutting concern that needs attention in the entire framework.
An example of the desired approach, IMHO, can be found in Angular Material (without comparing the libraries in their feature-richness :)
I suggest renaming this issue accordingly.

@zdrawku zdrawku changed the title Grid RTL Support RTL Support Sep 13, 2019
@zdrawku
Copy link
Contributor Author

zdrawku commented Sep 13, 2019

Thank you, @ItielBeeri. The issue is updated accordingly

@radomirchev
Copy link
Contributor

radomirchev commented Sep 24, 2019

Related #5212, #5903, #5904, #5905

@simeonoff simeonoff added the 🛠️ status: in-development Issues and PRs with active development on them label Oct 2, 2019
@simeonoff simeonoff added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: general RTL Support 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants