[sint] new presence subscription tests #481
Conversation
guusdk
force-pushed
the
sint_subscription
branch
2 times, most recently
from
28d2c23
to
6f26293
Compare
|
After grudgingly applying two other 'improvements', this PR fails once again on a Checkstyle-based rule. I'm giving up. |
There was a problem hiding this comment.
Please find my review inline.
I think I've mentioned this before, but some of those tests are more towards testing server behavior and not really about integration tests. I guess a few simple ones are fine for Smack itself, but if you keep the integration tests coming that primarly test server behavior, then we really should think about establishing a separate xmpp-c2s-server-integration-test project where those tests reside in. Such a project can easily be based on, and exploit, Smack's integration test framework.
...tion-test/src/main/java/org/jivesoftware/smack/subscription/SubscriptionIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tion-test/src/main/java/org/jivesoftware/smack/subscription/SubscriptionIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tion-test/src/main/java/org/jivesoftware/smack/subscription/SubscriptionIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tion-test/src/main/java/org/jivesoftware/smack/subscription/SubscriptionIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tion-test/src/main/java/org/jivesoftware/smack/subscription/SubscriptionIntegrationTest.java
Outdated
Show resolved
Hide resolved
...tion-test/src/main/java/org/jivesoftware/smack/subscription/SubscriptionIntegrationTest.java
Outdated
Show resolved
Hide resolved
This adds a few basic tests that verify that presence subscription stanzas are received 'as intended', notably when they include extension elements.
guusdk
force-pushed
the
sint_subscription
branch
from
10bd728
to
acbc4a5
Compare
guusdk
force-pushed
the
sint_subscription
branch
from
fb95417
to
9a90e7b
Compare
|
I've applied the feedback and rebased to the current HEAD of the Master branch for good measure. Using a low-level test is less straight-forward if it's desirable to be able to make use of provisioned user accounts, or a mix of connected and unconnected connections. I've experimented with using |
| * @throws Exception on anything unexpected or undesired. | ||
| */ | ||
| @SmackIntegrationTest | ||
| public void testSubscriptionRequestOffline(final AbstractXMPPConnection conOne, |
There was a problem hiding this comment.
Please correct me if I am wrong (for this and all potential following statements), but this seems to test primarily a server functionality (i.e., that a presence subscription test send while the recipient is offline, is delivered once the recipient comes online).
As such, it is probably not a good fit for Smack and instead for smack-sinttest-server-extensions
| * @throws Exception on anything unexpected or undesired. | ||
| */ | ||
| @SmackIntegrationTest | ||
| public void testSubscriptionRequestOfflineWithExtension(final AbstractXMPPConnection conOne, |
|
The tests to be added in this PR are now being added to the smack-sint-server-extensions project instead: XMPP-Interop-Testing/smack-sint-server-extensions#6 |
This adds a few basic tests that verify that presence subscription stanzas are received 'as intended', notably when they include extension elements.