chore: do not proxy sentry dsn #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added
skip-changelog
julienrbrt
requested review from
ilgooz,
jeronimoalbi and
Pantani
as code owners
github-actions
bot
added
component:ci
Pantani
previously approved these changes
Sep 16, 2024
julienrbrt
force-pushed
the
julien/sentry-2
branch
from
5410c71
to
aac64de
Compare
Pantani
approved these changes
Sep 17, 2024
|
@Mergifyio backport release/v28.x.y |
🟠 Waiting for conditions to match
|
|
https://github.com/Mergifyio backport release/v28.x.y |
🟠 Waiting for conditions to match
|
|
@Mergifyio backport release/v28.x.y |
🟠 Waiting for conditions to match
|
|
Looks this broken to me: https://status.mergify.com |
|
@Mergifyio backport release/v28.x.y |
✅ Backports have been created
|
julienrbrt
added a commit
that referenced
this pull request
Sep 17, 2024
* chore: do not proxy sentry dsn * linting * lint
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* chore: do not proxy sentry dsn * linting * lint (cherry picked from commit 3fb433d) # Conflicts: # ignite/cmd/testnet_inplace.go
julienrbrt
added a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way the Sentry client parses the DSN, it isn't possible to use a proxy.
Otherwise, the request will all fail due to a wrong DSN.
We should just hardcode it in ignite, which is fine IMHO as sentry doesn't deprecate the DSN.
I have seen other open source Go project do the same.
Opened https://github.com/ignite/infraconfig/pull/6 to delete the proxy from infra.