Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd): add missing --config handling #4323

Merged
merged 4 commits into from
Aug 28, 2024
Merged

fix(cmd): add missing --config handling #4323

merged 4 commits into from
Aug 28, 2024

Conversation

julienrbrt
Copy link
Member

Closes: #4291

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Aug 28, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Aug 28, 2024
@julienrbrt julienrbrt enabled auto-merge (squash) August 28, 2024 21:50
@julienrbrt julienrbrt merged commit 16a40f0 into main Aug 28, 2024
40 of 44 checks passed
@julienrbrt julienrbrt deleted the julien/missing-config-option branch August 28, 2024 21:52
mergify bot pushed a commit that referenced this pull request Aug 28, 2024
@julienrbrt @mergify
fix(cmd): add missing --config handling (#4323)
ec0ae44 
* fix(cmd): add missing `--config` handling

* cl

* cl++

(cherry picked from commit 16a40f0)

# Conflicts:
#	ignite/cmd/chain_debug.go
@mergify mergify bot mentioned this pull request Aug 28, 2024
Merged
julienrbrt added a commit that referenced this pull request Aug 29, 2024
@mergify @julienrbrt
fix(cmd): add missing --config handling (backport #4323) (#4325)
cb7b4a0 
* fix(cmd): add missing --config handling (#4323)

* fix(cmd): add missing `--config` handling

* cl

* cl++

(cherry picked from commit 16a40f0)

# Conflicts:
#	ignite/cmd/chain_debug.go

* updates

* cl

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
@BrewTestBot BrewTestBot mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init --config doesn't work with multiple config files
2 participants
@julienrbrt @Pantani