Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to matomo analytics (backport #4095) #4182

Merged
merged 4 commits into from
Jun 13, 2024
Merged

feat: migrate to matomo analytics (backport #4095) #4182

merged 4 commits into from
Jun 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 7, 2024

This is an automatic backport of pull request #4095 done by [Mergify](https://mergify.com).

@Pantani @mergify
feat: migrate to matomo analytics (#4095)
77eea75 
* add matomo anlytics

* matomo url

* add changelog

* matomo  analytics refacor

* build analytics url

* fix matomo request parameters

* remove unused parameters and improve readability

* remove unused matomo request response parser

* fix analytics data

* change the source name to github

* fix UTM values

* fix scaffold type condition

* remove gacli pkg

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit e49e11d)

# Conflicts:
#	ignite/internal/analytics/analytics.go
#	ignite/pkg/gacli/gacli.go
@mergify mergify bot added the conflicts label Jun 7, 2024
@mergify mergify bot requested a review from ilgooz as a code owner June 7, 2024 11:43
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jun 7, 2024

Cherry-pick of e49e11d has failed:

On branch mergify/bp/release/v28.x.y/pr-4095
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit e49e11df.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/cmd/version.go
	deleted:    ignite/pkg/gacli/doc.go
	new file:   ignite/pkg/matomo/matomo.go
	modified:   ignite/version/version.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   ignite/internal/analytics/analytics.go
	deleted by them: ignite/pkg/gacli/gacli.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@julienrbrt julienrbrt merged commit 9dae8dc into release/v28.x.y Jun 13, 2024
42 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4095 branch June 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees
No one assigned
Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:packages conflicts type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt