Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(root): fix keyring for tx commands #4026

Merged
merged 8 commits into from
Mar 19, 2024
Merged

fix(root): fix keyring for tx commands #4026

merged 8 commits into from
Mar 19, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 16, 2024

Description

All tx commands are not working because the keyring backend uses the wrong directory.

I failed to convert the address field to the address: alice.info. The key was not found [cosmos/cosmos-sdk@v0.50.5/crypto/keyring/keyring.go:538]

how to reproduce

  • Scaffold and run a chain:
ignite s chain mars && \
cd mars && \
ignite s list --yes user email &&
ignite c serve --clear-cache --reset-once
  • Try to perform a transaction:
marsd tx mars create-user test@test.com --chain-id mars --from alice --keyring-backend test
  • The result should be an error:
I failed to convert the address field to the address: alice.info. The key was not found [cosmos/cosmos-sdk@v0.50.5/crypto/keyring/keyring.go:538]

@Pantani Pantani changed the title Fix(keyring/root): Fix keyring for tx commands fix(keyring/root): fix keyring for tx commands Mar 16, 2024
@Pantani Pantani changed the title fix(keyring/root): fix keyring for tx commands fix(root): fix keyring for tx commands Mar 16, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more a client/v2 issue than a wiring issue. We have a fix upcoming upstream. In the meantime we can use latest commit from release/v0.50.x branch for client/v2

changelog.md Outdated Show resolved Hide resolved
@Pantani Pantani added the skip-changelog Don't check changelog for new entries label Mar 19, 2024
@Pantani Pantani enabled auto-merge (squash) March 19, 2024 18:28
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.06%. Comparing base (75331b0) to head (85b8793).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4026   +/-   ##
=======================================
  Coverage   26.06%   26.06%           
=======================================
  Files         304      304           
  Lines       25440    25440           
=======================================
+ Hits         6630     6632    +2     
+ Misses      18233    18232    -1     
+ Partials      577      576    -1     

see 1 file with indirect coverage changes

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Mar 19, 2024
@Pantani Pantani merged commit 6ec0274 into main Mar 19, 2024
46 of 48 checks passed
@Pantani Pantani deleted the fix/keyring-dir branch March 19, 2024 19:34
mergify bot pushed a commit that referenced this pull request Mar 19, 2024
* fix keyring for tx commands

* add changelog

* rollback client config changes

* rollback

* rollback some go.mod files

* rollback changelog

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 6ec0274)
julienrbrt pushed a commit that referenced this pull request Mar 19, 2024
* fix keyring for tx commands

* add changelog

* rollback client config changes

* rollback

* rollback some go.mod files

* rollback changelog

---------

Co-authored-by: Pantani <Pantani>
(cherry picked from commit 6ec0274)

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
julienrbrt pushed a commit that referenced this pull request May 29, 2024
* fix keyring for tx commands

* add changelog

* rollback client config changes

* rollback

* rollback some go.mod files

* rollback changelog

---------

Co-authored-by: Pantani <Pantani>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:templates skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants