fix: add missing tx.go file by default and enable cli if autocli does not exist

[Pantani]

Description

Scaffold the x/<module-name>/client/cli/tx.go by default, and enable the GetTxCmd() module command. Now, it is a little bit confusing. We need to uncomment the method to allow the CLI to command the package. If not enabled, the command appears without the args.

[julienrbrt]

What do you mean exactly? The only use case you need to uncomment it is for IBC command. Otherwise you should not create it as AutoCLI takes care of it.
A new chain in most cases should not need any cli code.

We should imho uncomment the GetTxCommand instead when scaffolding an IBC command, and let that file be created only for IBC commands.

[Pantani]

What do you mean exactly? The only use case you need to uncomment it is for IBC command. Otherwise you should not create it as AutoCLI takes care of it. A new chain in most cases should not need any cli code.

We should imho uncomment the GetTxCommand instead when scaffolding an IBC command, and let that file be created only for IBC commands.

If you scaffold a packet:
E.g.: ignite scaffold packet ibcPost title content --ack postID --module blog

and if you try to use the planetd tx ibcPost CLI command for this package, the command shows that it doesn't have arguments, and you can't use the command.

Now, I changed the PR to scaffold the tx.go only if it is an IBC module.

[julienrbrt]

Oh yes, I understand what is happening. It uses the default AutoCLI config for IBC, which we don't want in that case.

[julienrbrt]

The change makes sense, but I still don't think we should create the tx.go by default. The previous logic would create it only when it is an IBC module as well. I think only the module.go wiring was missing?

[julienrbrt]

tACK! One nit

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbf6931) 24.36% compared to head (311fc6b) 24.37%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3849      +/-   ##
==========================================
+ Coverage   24.36%   24.37%   +0.01%     
==========================================
  Files         294      294              
  Lines       24555    24547       -8     
==========================================
+ Hits         5982     5984       +2     
+ Misses      18036    18027       -9     
+ Partials      537      536       -1     

Files	Coverage Δ
ignite/templates/ibc/packet.go	0.00% <ø> (ø)

... and 1 file with indirect coverage changes