Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scaffold minimal chain #3835

Merged
merged 24 commits into from
Jan 16, 2024
Merged

feat: scaffold minimal chain #3835

merged 24 commits into from
Jan 16, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 9, 2023

Closes: #3665

Now ignite s chain mini --minimal --no-module should look very much like https://github.com/cosmosregistry/chain-minimal

ignite/templates/app/files/app/app.go.plush Outdated Show resolved Hide resolved
ignite/templates/app/app.go Outdated Show resolved Hide resolved
@Pantani
Copy link
Collaborator

Pantani commented Dec 12, 2023

can we add some integration tests for it?

@Pantani
Copy link
Collaborator

Pantani commented Dec 12, 2023

Some tests are falling

Ehsan-saradar
Ehsan-saradar previously approved these changes Jan 15, 2024
Copy link
Contributor

@Ehsan-saradar Ehsan-saradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt merged commit 1b76c2d into main Jan 16, 2024
39 of 43 checks passed
@julienrbrt julienrbrt deleted the julien/minimal branch January 16, 2024 10:30
@OpenCoderX
Copy link

When I scaffold a chain with '--minimal' there are unused dependencies generated which prevents build.

@julienrbrt
Copy link
Member Author

When I scaffold a chain with '--minimal' there are unused dependencies generated which prevents build.

Can you verify if you have goimports installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate minimal application
4 participants