Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change ignite apps to be able to run in any directory #3827

Merged
merged 6 commits into from
Dec 12, 2023
Merged

fix: change ignite apps to be able to run in any directory #3827

merged 6 commits into from
Dec 12, 2023

Conversation

jeronimoalbi
Copy link
Member

Closes #3826

@jeronimoalbi jeronimoalbi self-assigned this Dec 7, 2023
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. labels Dec 7, 2023
@jeronimoalbi jeronimoalbi marked this pull request as ready for review December 7, 2023 11:43
Ehsan-saradar
Ehsan-saradar previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@Ehsan-saradar Ehsan-saradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #3827 (40919ca) into main (b0dd6a6) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3827   +/-   ##
=======================================
  Coverage   24.24%   24.25%           
=======================================
  Files         292      292           
  Lines       24497    24516   +19     
=======================================
+ Hits         5939     5946    +7     
- Misses      18021    18032   +11     
- Partials      537      538    +1
Files Coverage Δ
ignite/cmd/plugin.go 28.05% <56.52%> (+0.08%) ⬆️
ignite/services/plugin/client_api.go 29.41% <43.47%> (+17.64%) ⬆️

... and 1 file with indirect coverage changes

Pantani
Pantani approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@Pantani Pantani merged commit c148343 into main Dec 12, 2023
43 checks passed
@Pantani Pantani deleted the fix/improve-ignite-app-client-api branch December 12, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@julienrbrt julienrbrt Awaiting requested review from julienrbrt julienrbrt is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

Assignees

@jeronimoalbi jeronimoalbi

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Ignite App commands to run outside blockchain app projects
3 participants
@jeronimoalbi @Pantani @Ehsan-saradar