Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): box testutil/sample for messages and old chains #1523

Merged
merged 8 commits into from
Sep 7, 2021
Merged

fix(template): box testutil/sample for messages and old chains #1523

merged 8 commits into from
Sep 7, 2021

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Sep 1, 2021

Bug description

  • Scaffold messages not box the testutil/sample pkg, used into the ValidateBasic tests;
  • Old chain already scaffold cannot scaffold the ValidateBasic tests because the testutil is already there, but not the sample pkg;

Solution

  • Create a NewEmbedWalker only for sample pkg
  • Add testutil scaffold for messages

@Pantani Pantani self-assigned this Sep 1, 2021
lumtis
lumtis previously approved these changes Sep 1, 2021
View reviewed changes
starport/templates/testutil/register.go Show resolved Hide resolved
@Pantani Pantani requested a review from lumtis September 1, 2021 16:10
@ilgooz ilgooz merged commit 3fd114e into develop Sep 7, 2021
@ilgooz ilgooz deleted the fix/box-testutil branch September 7, 2021 14:16
@Qdigital Qdigital mentioned this pull request Jul 31, 2022
Open
@vutting4221 vutting4221 mentioned this pull request Jul 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 1, 2022
Open
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@Pantani @ilgooz
fix(template): box testutil/sample for messages and old chains (ign…
ad7384e 
…ite#1523)

* fix the testutil box method for messages and already scaffolded chains

* add comments

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@lumtis lumtis lumtis approved these changes

@fadeev fadeev Awaiting requested review from fadeev

Assignees

@Pantani Pantani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pantani @ilgooz @lumtis