Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate tendermint/spm #1549

Closed
ilgooz opened this issue Sep 7, 2021 · 1 comment · Fixed by #1968 or #1971
Closed

deprecate tendermint/spm #1549

ilgooz opened this issue Sep 7, 2021 · 1 comment · Fixed by #1968 or #1971
Assignees
Milestone

Comments

@ilgooz
Copy link
Member

ilgooz commented Sep 7, 2021

and move its content under starport/pkg/.

the initial idea with tendermint/spm was to have a lean repo to keep collection of dependencies that can be used by starport scaffold chains.

we wanted to separate these packages from starport's repo because go geting starport takes lots of time due to commit history. but this is not always true. when you go get an untagged version of starport, yes it git clones (without depth 1) the whole repo. but if you just go get the latest tagged (release) version which is the default behaviour of go get, it's only 122MB and downloaded as a single file (e.g. https://proxy.golang.org/github.com/tendermint/starport/@v/v0.17.2.zip) through Go proxy this time.

so, I propose to move spm back to make things easier to maintain.

after deprecating, we can safely delete the tendermint/spm repo. this won't break existent chains because Go proxy will never delete a tagged and cached package.

@fadeev
Copy link
Contributor

fadeev commented Sep 8, 2021

Very interesting! Thanks for investigating this 👍 I would definitely prefer not to have spm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants