Merge branch 'main' into fix/add-ibc-cli

ignite · Dec 12, 2023 · 328ee87 · 328ee87
2 parents 4eb46c7 + 52c1d09
commit 328ee87
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -6,3 +6,4 @@
 # Docs
 *.md    @salmad3 @toschdev @ilgooz
 docs/*   @salmad3 @toschdev @ilgooz
+changelog.md @ilgooz @salmad3 @toschdev @jeronimoalbi @Pantani @julienrbrt @Ehsan-saradar
diff --git a/changelog.md b/changelog.md
@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- [#3831](https://github.com/ignite/cli/pull/3831) Correct ignite app gRPC server stop memory issue
 - [#3825](https://github.com/ignite/cli/pull/3825) Fix a minor Keplr type-checking bug in TS client
 - [#3836](https://github.com/ignite/cli/pull/3836) Add missing IBC commands for scaffolded chain
 

diff --git a/ignite/services/plugin/protocol.go b/ignite/services/plugin/protocol.go
@@ -117,7 +117,13 @@ func (c client) startClientAPIServer(api ClientAPI) (uint32, func()) {
 		return srv
 	})
 
-	return brokerID, func() { srv.Stop() }
+	stop := func() {
+		if srv != nil {
+			srv.Stop()
+		}
+	}
+
+	return brokerID, stop
 }
 
 type server struct {