Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location of "vn_simona" #75

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Fix location of "vn_simona" #75

merged 2 commits into from
Jan 21, 2022

Conversation

ckittl
Copy link
Member

@ckittl ckittl commented Jan 11, 2022

Resolves #72

@ckittl @johanneshiry
Fix location of "vn_simona"
9925e84 
test grid. It was partially in Dortmund and Berlin.

Co-authored-by: johanneshiry <johannes.hiry@tu-dortmund.de>
@ckittl ckittl added the enhancement New feature or request label Jan 11, 2022
@ckittl ckittl requested a review from a team January 11, 2022 08:52
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #75 (5c3601a) into dev (bf84784) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #75   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files         155      155           
  Lines        5745     5745           
  Branches       80       80           
=======================================
  Hits         4557     4557           
  Misses       1188     1188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf84784...5c3601a. Read the comment docs.

sebastian-peter
sebastian-peter approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well all nodes now rest at a single point, but for a test grid I think that is fine.

@johanneshiry
Copy link
Member

Well all nodes now rest at a single point, but for a test grid I think that is fine.

@sebastian-peter indeed the grid does not span such a wide area that the weather data would change, but it does if parts of the grid are in BER 😂

johanneshiry
johanneshiry approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@johanneshiry johanneshiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thx! :)

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (81.60% Estimated after merge)
  • No duplication informationNo duplication information (0.50% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@johanneshiry johanneshiry merged commit 0b41217 into dev Jan 21, 2022
@johanneshiry johanneshiry deleted the ck/#72-fixVnSimonaLocation branch January 21, 2022 12:00
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@johanneshiry johanneshiry johanneshiry approved these changes

Assignees

@johanneshiry johanneshiry

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Fix location of "vn_simona" test grid
3 participants
@ckittl @johanneshiry @sebastian-peter