Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated csv-files according to the new syntax #424

Merged
merged 12 commits into from
Feb 27, 2023
Merged

Updated csv-files according to the new syntax #424

merged 12 commits into from
Feb 27, 2023

Conversation

jo-bao
Copy link
Contributor

@jo-bao jo-bao commented Dec 15, 2022

resolves #216

@jo-bao jo-bao added the format Issues related to code formatting label Dec 15, 2022
@jo-bao jo-bao self-assigned this Dec 15, 2022
@danielfeismann
Copy link
Member

!test

@sebastian-peter sebastian-peter mentioned this pull request Feb 13, 2023
Merged
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
sebastian-peter
sebastian-peter requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just noticed that an addition to the changelog is missing, maybe you could provide that?

@jo-bao jo-bao marked this pull request as ready for review February 27, 2023 06:47
sebastian-peter
sebastian-peter approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I haven't checked all lines since they are in different orders now, but the files should have the same contents :)

@sebastian-peter sebastian-peter merged commit 2892f95 into dev Feb 27, 2023
@sebastian-peter sebastian-peter deleted the jb/#216-refresh-csv-grid-data branch February 27, 2023 20:10
@jo-bao jo-bao mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@jo-bao jo-bao

Labels
format Issues related to code formatting
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

vn_simona in SIMONA seems to use deprecated csv file version
3 participants
@jo-bao @danielfeismann @sebastian-peter