Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ConfigFailFast check for invalid dateTime configuration #411

Merged
merged 12 commits into from
Jan 24, 2023
Merged

Added ConfigFailFast check for invalid dateTime configuration #411

merged 12 commits into from
Jan 24, 2023

Conversation

vickybung1
Copy link
Contributor

Resolves #344

sebastian-peter
sebastian-peter requested changes Nov 23, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some super minor points from my side

src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala Outdated Show resolved Hide resolved
src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala Outdated Show resolved Hide resolved
src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala Outdated Show resolved Hide resolved
sebastian-peter
sebastian-peter approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@sebastian-peter sebastian-peter merged commit ef2fd24 into dev Jan 24, 2023
@sebastian-peter sebastian-peter deleted the vb/#344_fast_check branch January 24, 2023 15:51
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@t-ober t-ober Awaiting requested review from t-ober

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

Assignees

@vickybung1 vickybung1

Labels
None yet
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Add config fail fast check for simulationEndDateTime < simulationStartDateTime
2 participants
@vickybung1 @sebastian-peter