Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test due to change of PU in p.u. within PSU #295

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Fix test due to change of PU in p.u. within PSU #295

merged 2 commits into from
Jul 29, 2022

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Jul 29, 2022 •
edited
Loading

resolves #294

@danielfeismann danielfeismann added bug Something isn't working dependencies Pull requests that update a dependency file labels Jul 29, 2022
@danielfeismann danielfeismann self-assigned this Jul 29, 2022
@danielfeismann danielfeismann marked this pull request as ready for review July 29, 2022 08:50
@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #295 (b91b1b7) into dev (a39bfec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #295   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files         159      159           
  Lines        5839     5839           
  Branches       81       81           
=======================================
  Hits         4645     4645           
  Misses       1194     1194

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39bfec...b91b1b7. Read the comment docs.

sebastian-peter
sebastian-peter approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastian-peter sebastian-peter merged commit 84af182 into dev Jul 29, 2022
@sebastian-peter sebastian-peter deleted the df/#294_fix_test_unit_change_PSU branch July 29, 2022 11:14
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Fix tests due to changes in unit symbols of PowerSystemUtils
2 participants
@danielfeismann @sebastian-peter