Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying ParticipantConfigUtil #274

Merged
merged 7 commits into from
Jul 31, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #273

@sebastian-peter sebastian-peter added the code quality Code readability or efficiency is improved label Jun 28, 2022
@sebastian-peter sebastian-peter self-assigned this Jun 28, 2022
@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #274 (4629335) into dev (a5b7992) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #274      +/-   ##
==========================================
- Coverage   79.53%   79.50%   -0.04%     
==========================================
  Files         159      159              
  Lines        5835     5835              
  Branches       81       80       -1     
==========================================
- Hits         4641     4639       -2     
- Misses       1194     1196       +2     
Impacted Files Coverage Δ
...rc/main/scala/edu/ie3/simona/util/ConfigUtil.scala 54.07% <0.00%> (-2.36%) ⬇️
...du/ie3/simona/agent/grid/GridAgentController.scala 80.18% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b7992...4629335. Read the comment docs.

danielfeismann
danielfeismann previously approved these changes Jun 30, 2022
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 60 percent coverage85.71% Coverage (81.80% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the work!

@danielfeismann danielfeismann merged commit 7e4efb6 into dev Jul 31, 2022
@danielfeismann danielfeismann deleted the sp/#273-simplify-ParticipantConfigUtil branch July 31, 2022 16:22
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or efficiency is improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify ParticipantConfigUtil
2 participants