Update Changelog #240
Merged
Update Changelog #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfeismann
added
the
documentation
danielfeismann
requested review from
sebastian-peter,
sensarmad,
staudtMarius and
t-ober
|
Unsure also to add changes in documentation. What do you thing? |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #240 +/- ##
=======================================
Coverage 79.63% 79.63%
=======================================
Files 156 156
Lines 5751 5751
Branches 79 79
=======================================
Hits 4580 4580
Misses 1171 1171 Continue to review full report at Codecov.
|
sebastian-peter
requested changes
May 21, 2022
There was a problem hiding this comment.
Looks great, thanks for the work. I just have some minor comments, and at least one issue is missing: #220
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sebastian-peter
requested changes
May 23, 2022
|
!test |
This comment has been minimized.
This comment has been minimized.
t-ober
requested changes
May 24, 2022
This comment has been minimized.
This comment has been minimized.
sebastian-peter
approved these changes
May 24, 2022
sebastian-peter
requested review from
t-ober
and removed request for
sebastian-peter
staudtMarius
approved these changes
May 27, 2022
t-ober
approved these changes
May 27, 2022
|
!test |
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: edu.ie3:simona |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #221
Depends on #244