Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix variable height to elevationAngle #154

Merged
merged 12 commits into from
Mar 4, 2022
Merged

fix variable height to elevationAngle #154

merged 12 commits into from
Mar 4, 2022

Conversation

danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Feb 25, 2022 •
edited
Loading

Resolves #100

Also fixed:

  • Resolved an issue with depricated time series
  • Change weather sceme to COSMO

@danielfeismann danielfeismann added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 25, 2022
@danielfeismann danielfeismann added this to the Version 3.0 milestone Feb 25, 2022
@danielfeismann danielfeismann self-assigned this Feb 25, 2022
@sebastian-peter
Copy link
Member

This is blocked by ie3-institute/PowerSystemDataModel#443

@danielfeismann danielfeismann marked this pull request as ready for review March 2, 2022 10:50
@ckittl
Copy link
Member

ckittl commented Mar 3, 2022

Please also consider adapting the pv_input.csv files in the input directory.

@danielfeismann
Copy link
Member Author

Please also consider adapting the pv_input.csv files in the input directory.

done

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 60 percent coverage66.67% Coverage (81.50% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #154 (ffc2787) into dev (6acd7d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #154   +/-   ##
=======================================
  Coverage   79.24%   79.24%           
=======================================
  Files         155      155           
  Lines        5725     5725           
  Branches       79       79           
=======================================
  Hits         4537     4537           
  Misses       1188     1188
Impacted Files Coverage Δ
.../simona/service/weather/WeatherSourceWrapper.scala 40.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acd7d3...ffc2787. Read the comment docs.

sebastian-peter
sebastian-peter approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

t-ober
t-ober requested changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but in the WeatherSourceWrapper line 26 and WeatherSourceWrapperSpec line 11 the WeatherSource the WeatherSource gets renamed to PsdmWeatherSource. Shouldn't this be renamed too?

@t-ober t-ober merged commit 9c306ec into dev Mar 4, 2022
@t-ober t-ober deleted the df/#100-elevationAnlge-PvInputModel branch March 4, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@t-ober t-ober t-ober approved these changes

@johanneshiry johanneshiry Awaiting requested review from johanneshiry

@ckittl ckittl Awaiting requested review from ckittl

@sensarmad sensarmad Awaiting requested review from sensarmad

Assignees

@danielfeismann danielfeismann

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Adapt to changed PvInputModel
4 participants
@danielfeismann @sebastian-peter @ckittl @t-ober