Add HashWithState to increase its scalability #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunshenshi
changed the title
|
Please do not get me wrong on the question, but in which real-world situation would this initial state be helpful? The previous results of other hash would be enough, wouldn't they? |
|
consistent with circomlibjs. |
|
+1, this would be useful for us too. When hashing more than 16 values, it can be useful to chain hashes together, such that the hash of the last 16 values is the initial state of the next 16. Opened #61 before seeing this one. |
|
cc @OBrezhniev, would love some eyes on this if possible, thank you in advance! |
OBrezhniev
approved these changes
Feb 16, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.