Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#79 add molecule-docker support #80

Merged
merged 3 commits into from
Aug 24, 2021
Merged

#79 add molecule-docker support #80

merged 3 commits into from
Aug 24, 2021

Conversation

blalop
Copy link
Member

@blalop blalop commented Aug 20, 2021

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;
  • Add "idealista/benders" as reviewer

Description of the Change

Add molecule-docker installation.

Benefits

Starting molecule 3.1.0, molecule-docker is no longer part of molecule (see ansible/molecule#2811). Thus, this template requires manual installation of molecule-docker when using molecule >= 3.1.0. It would be interesing to add support in the template.

Possible Drawbacks

None

Applicable Issues

#79

@blalop blalop merged commit 4c2995e into develop Aug 24, 2021
@blalop blalop deleted the bugs/79 branch August 24, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants