Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): enable async overrides on net6 #811

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Dec 16, 2022

Implicitly include async overrides on NETCOREAPP3_1_OR_GREATER to include them when targeting .NET 6.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #811 (b174bc3) into master (cbb9e83) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
- Coverage   74.77%   74.73%   -0.05%     
==========================================
  Files          72       72              
  Lines        8501     8507       +6     
==========================================
+ Hits         6357     6358       +1     
- Misses       2144     2149       +5     
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Tar/TarBuffer.cs 72.72% <ø> (-0.90%) ⬇️
src/ICSharpCode.SharpZipLib/Tar/TarHeader.cs 84.53% <ø> (+0.05%) ⬆️
src/ICSharpCode.SharpZipLib/Tar/TarInputStream.cs 62.32% <ø> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piksel piksel merged commit c4009fd into master Dec 16, 2022
@piksel piksel deleted the fix/tar-async-net6 branch December 16, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant