Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress CA1707 warnings from LzwConstants #483

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Jul 14, 2020

The LzwConstants class has multiple CA1707 (Identifiers should not contain underscores) warnings from FxCop, but as they're public fields and renaming them would be a breaking change (and they might be named like thay because they're copied from some other spec?), this just suppresses the warning rather than doing anything with the names.

There are several similar analyzer warnings, but i'm putting this one in its own PR so i can also query about LzwConstants being a sealed class rather than a static class -> not sure if changing that would count as an ABI break, but #351 does that change in GZipConstants so.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel piksel merged commit 3835f0c into icsharpcode:master Aug 7, 2020
@Numpsy Numpsy deleted the rw/code_analyzers/lzw_1707 branch August 7, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants