-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3246: Choppy scrolling when scrolling fast after smooth scrolling introduction #3248
Conversation
…th scrolling introduction
@ElektroKill Can you please give the PR's action build artefacts a try? |
I've compiled the build from the source and here are my observations:
I have my Windows settings so that one scroll = 3 lines. Before the smooth scrolling changes it would scroll 3 lines, now it scrolls around 36 lines which is quite an increase. This increase in scrolling affects other components, such as the treeview. |
…l scroll viewers.
@ElektroKill can you try the latest version? Should now cover all different scenarios. |
I took a look at the latest commit and the scrolling in the main text view seems to behave correctly when it comes to how much a single scroll operation is scrolling, however, the smoothness is back to what it used to be before the smooth scrolling changes. When it comes to scrolling in the Treeview, I can observe some weird jumping and snapping occasionally when the Treeview will jump/scroll much further than expected. This can be observed in the video found below. Throughout the video, I'm scrolling with the same speed on the scroll wheel. First, the behavior in the latest build from this PR is demonstrated, and later a build from before any of the scrolling changes is shown. |
It's now also activated on the test view. What you call "jumping" and "snapping" is a dynamic acceleration when you turn the mouse wheel very fast, to make it easier to scroll large lists. |
I can confirm the smooth scrolling is now working in the text view. Regarding the dynamic acceleration? Would it be possible to add an option in settings to enable/disable it? I'm really not a fan of mouse pointer acceleration and scrolling acceleration as in my opinion it makes things more unpredictable. |
@ElektroKill I just removed it |
Thanks for sorting out smooth scrolling! |
#3246
Problem
Choppy scrolling when scrolling fast after smooth scrolling introduction
Solution
Update TomsToolbox.Wpf package with fixed behavior.