Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "loading" being passed as html props to div error #1944

Merged
merged 1 commit into from
May 20, 2021

Conversation

justincorrigible
Copy link
Member

Description of changes

This selective props forwarding prevents the following error message, which comes up as a result of @emotion passing loading to the Container's div as an HTML attribute (which is a WIP for lazyloading of images whatwg/html#3752).

image

Type of Change

  • Bug
  • Styling
  • New Feature

Checklist before requesting review:

  • Design (select one):
    • Matches design:
      • component sizes, spacing, and styles
      • font size, weight, colour
      • spelling has been double checked
    • No design provided, screenshot of changes included in PR
    • No changes to UI
  • UI Kit (select one):
    • New Components with storybook stories created
    • Modified Existing components and updates stories
    • No new UIKit components or changes
  • Feature is minimally responsive
  • Manual testing of UI feature
  • Add copyrights to new files
  • Connected ticket to PR

@justincorrigible justincorrigible merged commit edc58e5 into develop May 20, 2021
@justincorrigible justincorrigible deleted the fix/container-loading-bug branch May 20, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants