Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): ensure ibis.random() generates a new value per call #10173

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Sep 19, 2024

Fixes #10142.

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2 snapshot failures and a new XPASS 🥳

@cpcloud cpcloud added this to the 10.0 milestone Sep 19, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend labels Sep 19, 2024
@cpcloud cpcloud enabled auto-merge (squash) September 19, 2024 19:16
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry in Cursed Knowledge?

@cpcloud
Copy link
Member

cpcloud commented Sep 19, 2024

PLEASE

@cpcloud cpcloud merged commit 1667f43 into ibis-project:main Sep 19, 2024
76 checks passed
@jcrist jcrist deleted the ensure-random-unique-per-row branch September 19, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Sampling on MSSQL Table
3 participants