chore(mysql): port to MySQLdb instead of pymysql #10077
Merged
+136
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
cpcloud
commented
Sep 10, 2024
| user=user, | ||
| host=host, | ||
| host="127.0.0.1" if host == "localhost" else host, |
There was a problem hiding this comment.
localhost will try to use a socket, which is different from the behavior of pymysql, so I made localhost usage backwards compatible. There's a unix_socket argument if anyone really needs it.
cpcloud
force-pushed
the
dump-pymysql
branch
8 times, most recently
from
6890c17
to
bb1eecb
Compare
cpcloud
force-pushed
the
dump-pymysql
branch
2 times, most recently
from
3df30da
to
70062ef
Compare
cpcloud
force-pushed
the
dump-pymysql
branch
from
70062ef
to
78d3a09
Compare
gforsyth
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces pymysql with mysqlclient, mostly out of frustration with bizarre GC behavior discovered during #10055. I think this is probably a breaking change due to some changes in how types are inferred for JSON, INET and UUID types.
BREAKING CHANGE: Ibis now uses the
MySQLdbdriver. You may need to install MySQL client libraries to build the extension.