පරිවර්තන නිවරදි කිරීම #1475
පරිවර්තන නිවරදි කිරීම #1475
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1475 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 176 176
Lines 1770 1770
Branches 411 411
=======================================
Hits 1769 1769
Misses 1 1
Continue to review full report at Codecov.
|
|
the source file should be this https://github.com/moment/moment/blob/develop/locale/si.js |
謝謝! I already found it and added PR. you can merge this changes meanwhile however let me know if i need to provide more details about that |
|
I'm not sure if we should keep the same with momentjs or not? |
Same PR for that repository moment/moment#5877
May be, someone from dayjs able to join to momentjs for review PRs for example. I'm not sure if that necessary or convenient otherwise you may able to take a look at important PRs randomly and apply them to dayjs. |
|
Thanks, I'll mark this PR for more code review by native speakers before it gets merged. |
|
@iamkun @Aikatsui notified me; I'm sinhalese language native speaker.
|
can you merge this? see another resource with pronunciation https://masteranylanguage.com/c/b/o9ly878fJ/98-Sinhala-MonthsOfYear-Learn-Step-By-Step (first three rows contain 12 months loan names. you can easily recognize them because it has pronunciation and then correct 12 months names) |
|
sure, LGTM |
## [1.10.7](v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](#1614)) ([3393f2a](3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](#1627)) ([b5a1391](b5a1391)) * add format object type to type file ([#1572](#1572)) ([5a79cc6](5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](#1611)) ([252585b](252585b)) * narrow type for `add` and `subtract` ([#1576](#1576)) ([1686962](1686962)) * update customParseFormat plugin strict x X parsing ([#1571](#1571)) ([08adda5](08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](#1609)) ([255dc54](255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](#1608)) ([7a8467c](7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](#1566)) ([755fc8b](755fc8b)) * update Sinhalese [si] locale month name ([#1475](#1475)) ([63de2a8](63de2a8)) * update utcOffset plugin type file ([#1604](#1604)) ([f68e4b1](f68e4b1))
|
🎉 This PR is included in version 1.10.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.10.7](iamkun/dayjs@v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](iamkun/dayjs#1614)) ([3393f2a](iamkun/dayjs@3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](iamkun/dayjs#1627)) ([b5a1391](iamkun/dayjs@b5a1391)) * add format object type to type file ([#1572](iamkun/dayjs#1572)) ([5a79cc6](iamkun/dayjs@5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](iamkun/dayjs#1611)) ([252585b](iamkun/dayjs@252585b)) * narrow type for `add` and `subtract` ([#1576](iamkun/dayjs#1576)) ([1686962](iamkun/dayjs@1686962)) * update customParseFormat plugin strict x X parsing ([#1571](iamkun/dayjs#1571)) ([08adda5](iamkun/dayjs@08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](iamkun/dayjs#1609)) ([255dc54](iamkun/dayjs@255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](iamkun/dayjs#1608)) ([7a8467c](iamkun/dayjs@7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](iamkun/dayjs#1566)) ([755fc8b](iamkun/dayjs@755fc8b)) * update Sinhalese [si] locale month name ([#1475](iamkun/dayjs#1475)) ([63de2a8](iamkun/dayjs@63de2a8)) * update utcOffset plugin type file ([#1604](iamkun/dayjs#1604)) ([f68e4b1](iamkun/dayjs@f68e4b1))
## [1.10.7](iamkun/dayjs@v1.10.6...v1.10.7) (2021-09-10) ### Bug Fixes * Add Spanish (Mexico) [es-mx] locale ([#1614](iamkun/dayjs#1614)) ([3393f2a](iamkun/dayjs@3393f2a)) * Add Arabic (Iraq) [ar-iq] locale ([#1627](iamkun/dayjs#1627)) ([b5a1391](iamkun/dayjs@b5a1391)) * add format object type to type file ([#1572](iamkun/dayjs#1572)) ([5a79cc6](iamkun/dayjs@5a79cc6)) * duration plugin when parsing duration from ISO string, set missing components to 0 instead of NaN ([#1611](iamkun/dayjs#1611)) ([252585b](iamkun/dayjs@252585b)) * narrow type for `add` and `subtract` ([#1576](iamkun/dayjs#1576)) ([1686962](iamkun/dayjs@1686962)) * update customParseFormat plugin strict x X parsing ([#1571](iamkun/dayjs#1571)) ([08adda5](iamkun/dayjs@08adda5)) * update Lithuanian [lt] locale spelling for single month ([#1609](iamkun/dayjs#1609)) ([255dc54](iamkun/dayjs@255dc54)) * Update Norwegian Bokmål [nb] local yearStart 4 ([#1608](iamkun/dayjs#1608)) ([7a8467c](iamkun/dayjs@7a8467c)) * update plugin advancedFormat `isValid` validation ([#1566](iamkun/dayjs#1566)) ([755fc8b](iamkun/dayjs@755fc8b)) * update Sinhalese [si] locale month name ([#1475](iamkun/dayjs#1475)) ([63de2a8](iamkun/dayjs@63de2a8)) * update utcOffset plugin type file ([#1604](iamkun/dayjs#1604)) ([f68e4b1](iamkun/dayjs@f68e4b1))
This fix incorrect localization for sinhalese/sinhala language (sri lanka). Below describe using examples
e.g. January
current: ජනවාරි (janavaari)
update: දුරුතු (duruthu)
e.g. August
current: අගෝස්තු (agoosthu)
update: නිකිණි (nikini)
I saw @aadityataparia @iamkun have updated
si.jsthen do you remember the source of that resources? if then it will helpful for me to follow and re-correct.