Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.weekdays() improvement #936

Closed
OlivierSte opened this issue Jun 23, 2020 · 2 comments · Fixed by #938
Closed

.weekdays() improvement #936

OlivierSte opened this issue Jun 23, 2020 · 2 comments · Fixed by #938
Labels
released

Comments

@OlivierSte
Copy link

OlivierSte commented Jun 23, 2020 •
edited
Loading

Describe the bug

Currently .weekdaysMin() and .weekdaysShort() always return formatted weekdays starting at index 0.

Expected behavior

Locale files having a weekStart property should return the weekdays ordered accordingly.

In Moment you can pass a boolean to make it locale aware.

As of 2.13.0 you can pass a bool as the first parameter of the weekday functions. If true, the weekdays will be returned in locale specific order.

Information

  • Day.js Version: 1.8.28
iamkun added a commit that referenced this issue Jun 24, 2020
@iamkun
fix: LocaleData plugin supports locale order
759456a 
fix #936
@iamkun iamkun mentioned this issue Jun 24, 2020
Merged
iamkun added a commit that referenced this issue Jun 30, 2020
@iamkun
fix: LocaleData plugin supports locale order (#938)
62f429d 
fix #936
@iamkun
Copy link
Owner

iamkun commented Jun 30, 2020

Feature added, thanks.

iamkun pushed a commit that referenced this issue Jul 2, 2020
@semantic-release-bot
chore(release): 1.8.29 [skip ci]
f236aef 
## [1.8.29](v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](#950)) ([f0fc12a](f0fc12a))
* LocaleData plugin supports locale order ([#938](#938)) ([62f429d](62f429d)), closes [#936](#936)
* Update type definition to support array format ([#945](#945)) ([81d4740](81d4740)), closes [#944](#944)
* Update type definition to support strict mode ([#951](#951)) ([8d54f3f](8d54f3f))
@iamkun
Copy link
Owner

iamkun commented Jul 2, 2020

🎉 This issue has been resolved in version 1.8.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 2, 2020
@awesomund awesomund mentioned this issue Feb 22, 2022
Open
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.29 [skip ci]
3615770 
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.29 [skip ci]
871ce85 
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([f0fc12a](iamkun/dayjs@f0fc12a))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([62f429d](iamkun/dayjs@62f429d)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([81d4740](iamkun/dayjs@81d4740)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([8d54f3f](iamkun/dayjs@8d54f3f))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this issue Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.29 [skip ci]
5a12bef 
## [1.8.29](iamkun/dayjs@v1.8.28...v1.8.29) (2020-07-02)

### Bug Fixes

* Duration plugin supports parse ISO string with week (W) ([#950](iamkun/dayjs#950)) ([0472455](iamkun/dayjs@0472455))
* LocaleData plugin supports locale order ([#938](iamkun/dayjs#938)) ([e244af4](iamkun/dayjs@e244af4)), closes [#936](iamkun/dayjs#936)
* Update type definition to support array format ([#945](iamkun/dayjs#945)) ([eb50029](iamkun/dayjs@eb50029)), closes [#944](iamkun/dayjs#944)
* Update type definition to support strict mode ([#951](iamkun/dayjs#951)) ([86f72a9](iamkun/dayjs@86f72a9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: LocaleData plugin supports locale order iamkun/dayjs
2 participants
@iamkun @OlivierSte