feat: support core modules with node: prefix
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of versions 14.18.0 and 16.0.0, core modules can also be identified by prepending `node:` to the module name. This change patches the RegExp used to determine whether a module is a code module by allowing an optional `node:` prefix.
|
@iambumblehead I'm not sure if this is ok, or if it would be better to remove the |
|
@gmahomarf this looks like an excellent change with an excellent unit-test. thank you! let's publish right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of versions 14.18.0 and 16.0.0, core modules can also be identified
by prepending
node:to the module name. This change patches theRegExp used to determine whether a module is a code module by allowing
an optional
node:prefix.