Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mv tests to subfolders with own packagejson #80

Merged
merged 21 commits into from
Jul 23, 2022

Conversation

iambumblehead
Copy link
Owner

This PR makes the following changes,

  • Adds typescript and node-native runner tests for windows CI. Previously, these were disabled because there was no condition to detect node v18+ in windows CI. The detect-node package is added to enable tests requiring node v18+,
  • Renames esmockLoader.mjs to esmockLoader.js. Esbuild minification would not preserve the .mjs extension and the extension isn't needed because it was used to trigger "esm" mode when esmock previously attempted to support cjs unit-tests,
  • Uses runner-specific test folders. These allow each test folder to define their own tsconfig.json, specific version of a dependency and other things,
  • Updates a test that depended on an old package version to use a local module instead. The old package and the locale module reproduce a babel-generated type of CJS file.

@iambumblehead iambumblehead force-pushed the mv-tests-to-subfolders-with-own-packagejson branch from 5c37972 to 1668d7e Compare July 23, 2022 22:04
@iambumblehead iambumblehead merged commit 137383a into master Jul 23, 2022
@iambumblehead iambumblehead deleted the mv-tests-to-subfolders-with-own-packagejson branch July 23, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants