Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit login page, update bloc for register, create register form #23

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Edit login page, update bloc for register, create register form #23

merged 9 commits into from
Oct 19, 2023

Conversation

12henbx
Copy link
Collaborator

@12henbx 12henbx commented Oct 14, 2023 •
edited
Loading

Description

// ToDo: @12henbx

From task

Proposed Changes

  • Edit login page,
  • Update bloc for register,
  • Create register form,
  • Add assets
  • Fix typo Gadjah Mada

Updated (1) SS

@atnanahidiw atnanahidiw linked an issue Oct 15, 2023 that may be closed by this pull request
[Task] User Management - Make Personal Info Form #20
Closed
atnanahidiw
atnanahidiw requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@atnanahidiw atnanahidiw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 👍👍👍 I can see my data is recorded in DB successfully
but looks like it's still buggy when I logout -> login again
please also fix my comment below

app/lib/core/constants/bebrasBiroDropdown.dart Outdated Show resolved Hide resolved
app/lib/core/constants/indonesiaProvince.dart Outdated Show resolved Hide resolved
app/lib/features/authentication/register/bloc/user_register_bloc.dart Show resolved Hide resolved
app/lib/features/authentication/register/presentation/pages/register_page.dart Outdated Show resolved Hide resolved
app/lib/features/authentication/register/presentation/pages/register_page.dart Outdated Show resolved Hide resolved
app/lib/features/authentication/register/presentation/widgets/custom_date_picker.dart Outdated Show resolved Hide resolved
app/lib/features/authentication/register/presentation/widgets/custom_date_picker.dart Outdated Show resolved Hide resolved
app/lib/features/authentication/signin/presentation/pages/sign_in_page.dart Outdated Show resolved Hide resolved
app/lib/features/main/presentation/pages/main_page.dart Show resolved Hide resolved
@atnanahidiw
Copy link
Collaborator

can use the text box at the bottom to note the changes @12henbx (like this) ^^

atnanahidiw
atnanahidiw approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@atnanahidiw atnanahidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@12henbx 12henbx merged commit f7d747b into main Oct 19, 2023
1 check failed
@atnanahidiw atnanahidiw deleted the register-page-session branch October 24, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atnanahidiw atnanahidiw atnanahidiw approved these changes

@ArvinCS ArvinCS Awaiting requested review from ArvinCS

@gmochid gmochid Awaiting requested review from gmochid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] User Management - Make Personal Info Form
2 participants
@12henbx @atnanahidiw