Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cozytouch server name to include whitelabeled brands (Thermor, Sauter) #1350

Closed
wants to merge 1 commit into from

Conversation

carsso
Copy link

@carsso carsso commented Sep 1, 2024

Thermor Cozytouch and Sauter Cozytouch are simply whitelabeled Atlantic Cozytouch bridges and apps, using the same servers and accounts.

To ease usage for people buying those whitelabaled products, changing server name to "Cozytouch (Atlantic, Thermor, Sauter)" instead of "Atlantic Cozytouch".
It will be easier to find and choose the right server if you bought a Cozytouch bridge from Thermor or Sauter.

Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add extra items to the server list for Thermor_Cozytouch and Sauter_Cozytouch? They are using a different mobile app and this will allow us to add the manufacturer name in as well.

If they switch their servers in the future, we can migrate users without needing any configuration changes.

@carsso
Copy link
Author

carsso commented Sep 6, 2024

Up to you.
I thought about that possibility before discovering the 3 mobile apps are also using the same backend/user database and my account works exactly the same on all 3 apps.

@iMicknl
Copy link
Owner

iMicknl commented Sep 6, 2024

My preference would be to have 3 different entries, because (unfortunately) I have seen server migrations / authentication changes in the past. Are you willing to do the PR, or shall I work on this?

@carsso
Copy link
Author

carsso commented Sep 6, 2024

I can update that PR accordingly :) Unless you'd like to do it yourself :)
No guarantee I'll be able to do it this weekend though.

@iMicknl
Copy link
Owner

iMicknl commented Sep 6, 2024

Working on a new PR: #1358 (since I am now working on a new release for HA anyways ). But your contribution is much valued!

@iMicknl
Copy link
Owner

iMicknl commented Sep 6, 2024

Replaced by #1358, thanks for your contribution!

@iMicknl iMicknl closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants