Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide arguments that are encrypted #12

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

bwillis
Copy link
Contributor

@bwillis bwillis commented Feb 2, 2019

Sidekiq enterprise supports encrypting arguments. When logging them, they are long unintelligible strings that don't provide value. This diff adds detection for when arguments are encrypted and replaces it with a string '[ENCRYPTED]'.

Sidekiq enterprise supports encrypting arguments. When logging them, they are long and unintelligible strings that don't provide value. This diff adds detection for when arguments are encrypted and replaces it with a string '[ENCRYPTED]'.
Copy link
Owner

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bwillis and thanks for this contribution.
This indeed looks like a good addition, especially for those who have the enterprise Sidekiq license.

@iMacTia iMacTia merged commit 409186d into iMacTia:master Feb 4, 2019
@bwillis
Copy link
Contributor Author

bwillis commented Feb 5, 2019

Thanks! 🌈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants