fix(script_translator): always_show_comments also applies to phrases

Closes rime#272, Closes rime#419
i3thuan5 · Jan 3, 2022 · 4f7baaa · 4f7baaa
1 parent 10a309e
commit 4f7baaa
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/rime/gear/script_translator.cc b/src/rime/gear/script_translator.cc
@@ -472,7 +472,9 @@ an<Candidate> ScriptTranslation::Peek() {
   if (candidate_->comment().empty() && (translator_->sutsoo_lomaji() || candidate_->type() != "sentence")) {
     auto spelling = syllabifier_->GetOriginalSpelling(*candidate_);
     bool sichoanlosu = SiChoanLoSu(candidate_->text(), spelling);
-    if (!spelling.empty() && !sichoanlosu) {
+    if (!spelling.empty() && !sichoanlosu &&
+        (translator_->always_show_comments() ||
+          spelling != candidate_->preedit())) {
       candidate_->set_comment(/*quote_left + */spelling/* + quote_right*/);
     }
   }
@@ -486,9 +488,6 @@ void ScriptTranslation::PrepareCandidate() {
     return;
   }
   if (sentence_) {
-    if (sentence_->preedit().empty()) {
-      sentence_->set_preedit(syllabifier_->GetPreeditString(*sentence_));
-    }
     candidate_ = sentence_;
     return;
   }