Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the commented out async code #1761

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

VIKTORVAV99
Copy link
Contributor

There was some code that was commented out that should be more performant and smaller than the existing code. This was done to avoid pulling in regenerator runtimes in the past but it seems this is no longer an issue and can be used without doing so.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit 5c3c3eb into i18next:master Jul 15, 2024
8 checks passed
@adrai
Copy link
Member

adrai commented Jul 15, 2024

Do you need a new release with this or can this wait?

@coveralls
Copy link

Coverage Status

coverage: 97.11% (+0.09%) from 97.023%
when pulling 7aa1686 on VIKTORVAV99:use_the_commented_out_async_code
into b1ad62a on i18next:master.

@VIKTORVAV99
Copy link
Contributor Author

Do you need a new release with this or can this wait?

This can wait, I have some other PRs planned as well 🙂

@VIKTORVAV99 VIKTORVAV99 deleted the use_the_commented_out_async_code branch July 15, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants