Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Translation component types #1509

Merged
merged 2 commits into from
Jun 3, 2022
Merged

fix Translation component types #1509

merged 2 commits into from
Jun 3, 2022

Conversation

vovsemenv
Copy link
Contributor

closes #1508

@coveralls
Copy link

coveralls commented Jun 2, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 95.951% when pulling c6b01ce on vovsemenv:fix-translation-types into cc73dba on i18next:master.

@adrai adrai requested a review from pedrodurek June 2, 2022 20:47
pedrodurek
pedrodurek approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@pedrodurek pedrodurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me! Thanks @vovsemenv

@vovsemenv
Copy link
Contributor Author

@pedrodurek found this problem also for withTranslation, can you check it out too

@pedrodurek
Copy link
Member

Sounds good!

@vovsemenv
Copy link
Contributor Author

@adrai can you please release this today 🪄?

@adrai adrai merged commit f59657c into i18next:master Jun 3, 2022
@adrai
Copy link
Member

adrai commented Jun 3, 2022

sorry, in this time zone we were already sleeping...
just released v11.16.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrodurek pedrodurek pedrodurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong prop typings translation component
4 participants
@vovsemenv @coveralls @pedrodurek @adrai