Fix Trans component to support react 18 types #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrodurek
force-pushed
the
fix-trans-types-react-18
branch
from
7dddb80
to
f607081
Compare
|
included in v11.16.8 |
cellog
reviewed
May 16, 2024
Comment on lines
+105
to
+109
| declare module 'react' { | ||
| interface HTMLAttributes { | ||
| children?: ReactNode | ObjectOrNever; | ||
| } | ||
| } |
There was a problem hiding this comment.
this override is breaking all components that use render props when upgrading to React 18. We can patch this away, but I would strongly encourage NOT overriding generic types for all components. Can't it be limited to just the Trans component? A sledgehammer can't be the only solution when a scalpel will do?
There was a problem hiding this comment.
Feel free to provide a PR with a better solution that works.
// @marcalexiei do you know about this?
There was a problem hiding this comment.
@cellog extending is different from overriding. Share a minimal reproducible example so we can see how we can help you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1490 and #1483
Checklist
npm run testChecklist (for documentation change)