Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1444 - add values field to Plural component in macros #1446

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fixes #1444 - add values field to Plural component in macros #1446

merged 1 commit into from
Feb 8, 2022

Conversation

mwalkerr
Copy link
Contributor

@mwalkerr mwalkerr commented Feb 7, 2022 •
edited
Loading

Fixes #1444

Checklist

  • [ x] only relevant code is changed (make a diff before you submit the PR)
  • [ x] run tests npm run test
  • [x ] tests are included

@mwalkerr mwalkerr mentioned this pull request Feb 7, 2022
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling 3c4d287 on mwalkerr:master into e91ed94 on i18next:master.

@adrai adrai requested a review from pedrodurek February 7, 2022 21:24
pedrodurek
pedrodurek approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@pedrodurek pedrodurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@mwalkerr
Copy link
Contributor Author

mwalkerr commented Feb 8, 2022

Awesome! How do I merge this?

@adrai adrai merged commit 1b7fbca into i18next:master Feb 8, 2022
@adrai
Copy link
Member

adrai commented Feb 8, 2022

Thank you for your contribution. It's included in v11.15.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrodurek pedrodurek pedrodurek approved these changes

Assignees

@pedrodurek pedrodurek

Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PluralProps doesn't include values
5 participants
@mwalkerr @coveralls @adrai @pedrodurek @mwalker-rivian