fix: unescape html in Trans #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this should be an optional behaviour - can't really guess if there are side effects on existing projects? @adrai what do you think? |
|
The content should escape when extracting Trans content, but I do not use saveMissing. It may be a breaking change unless you can share translation memory between escaped and unescaped versions. |
|
my gut feeling says, this should only be introduced with a new Trans prop (and/or react option) that enables this |
|
@cuyl can you adapt the PR accordingly? |
|
@adrai Sure, please check it out |
|
@jamuhl lgtm (maybe also a react init option?) |
|
@adrai lgtm...guess react init option could be added in a later stage if really used that often? |
|
published in react-i18next@11.15.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1424