Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined from conditional type #1410

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Remove undefined from conditional type #1410

merged 2 commits into from
Nov 22, 2021

Conversation

pedrodurek
Copy link
Member

Closes #1407

Before:
Screenshot 2021-11-22 at 10 42 18 AM

After:
Screenshot 2021-11-22 at 10 42 28 AM

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.057% when pulling 359d74b on pedrodurek:fix-type-issue into d0625a9 on i18next:master.

@adrai adrai merged commit 9f11f66 into i18next:master Nov 22, 2021
@adrai
Copy link
Member

adrai commented Nov 22, 2021

included in v11.14.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error when used with typescript 4.5.2
3 participants
@pedrodurek @coveralls @adrai