Add optional defaultNS #1050
Merged
Add optional defaultNS #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be able to publish this after my holidays (this weekend, early next week) |
rosskevin
suggested changes
Feb 12, 2020
src/index.d.ts
Outdated
| @@ -98,6 +98,7 @@ export function withTranslation( | |||
|
|
|||
| export interface I18nextProviderProps { | |||
| i18n: i18n; | |||
| defaultNS: string; | |||
There was a problem hiding this comment.
This is not a required property, only i18n is. This should be defaultNS?: string. Leaving the test as-is and adding another would prove this true in the future.
rosskevin
approved these changes
Feb 14, 2020
|
was published in react-i18next@11.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1049