ALTAPPS-1034: Shared challenges #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…34/shared_customizable_challenges
github-actions
bot
added
shared
XanderZhu
requested changes
Nov 18, 2023
shared/src/commonMain/kotlin/org/hyperskill/app/core/view/mapper/date/SharedDateFormatter.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/org/hyperskill/app/core/view/mapper/date/SharedDateFormatter.kt
Outdated
Show resolved
Hide resolved
...ommonMain/kotlin/org/hyperskill/app/challenges/widget/presentation/ChallengeWidgetFeature.kt
Show resolved
Hide resolved
.../kotlin/org/hyperskill/app/challenges/widget/presentation/ChallengeWidgetActionDispatcher.kt
Outdated
Show resolved
Hide resolved
...ommonMain/kotlin/org/hyperskill/app/challenges/widget/presentation/ChallengeWidgetReducer.kt
Outdated
Show resolved
Hide resolved
...d/src/commonMain/kotlin/org/hyperskill/app/challenges/widget/presentation/StateExtentions.kt
Outdated
Show resolved
Hide resolved
...ommonMain/kotlin/org/hyperskill/app/challenges/widget/presentation/ChallengeWidgetReducer.kt
Outdated
Show resolved
Hide resolved
...ommonMain/kotlin/org/hyperskill/app/challenges/widget/presentation/ChallengeWidgetFeature.kt
Outdated
Show resolved
Hide resolved
|
In general, looks nice! |
XanderZhu
added
awaiting changes
ivan-magda
added
awaiting review
XanderZhu
approved these changes
Nov 19, 2023
XanderZhu
added
ready to pull
|
@ivan-magda |
ivan-magda
deleted the
feature/ALTAPPS-1034/shared_customizable_challenges
branch
@XanderZhu merged |
vladkash
reviewed
Nov 20, 2023
.../kotlin/org/hyperskill/app/challenges/widget/presentation/ChallengeWidgetActionDispatcher.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
#ALTAPPS-1034
Checklist
Before Code Review:
Description
HomeFeature.Stateinternal, provideHomeFeature.ViewStateto platforms.ChallengesDataComponentfor remote data loadingChallengeWidgetComponentfor challenge widget UI and behaviorChallengeWidgetFeatureintoHomeFeature. On Android, challenge widget is always in anIdlestate.