ALTAPPS-1030: [Shared, iOS] Fill blanks problem onboarding modal #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
shared
ivan-magda
changed the title
ivan-magda
changed the title
XanderZhu
approved these changes
Nov 14, 2023
ivan-magda
deleted the
feature/ALTAPPS-1030/shared_ios_fill_blanks_onboarding
branch
vladkash
reviewed
Nov 15, 2023
Comment on lines
7
to
+13
| fun isParsonsOnboardingShown(): Boolean | ||
| fun setParsonsOnboardingShown(isShown: Boolean) | ||
|
|
||
| fun isFillBlanksInputModeOnboardingShown(): Boolean | ||
| fun setFillBlanksInputModeOnboardingShown(isShown: Boolean) | ||
| fun isFillBlanksSelectModeOnboardingShown(): Boolean | ||
| fun setFillBlanksSelectModeOnboardingShown(isShown: Boolean) |
There was a problem hiding this comment.
Maybe here it would be better to use problem type to have only one method for caching. WIth adding new problem types onboardings it would be easier to support
| * { | ||
| * "route": "/learn/step/1", | ||
| * "action": "hidden", | ||
| * "part": "parsons_problem_onboarding_modal", |
There was a problem hiding this comment.
in such comments we usually add all possible values like parsons_problem_onboarding_modal | fill_blanks_problem_onboarding_modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack Issues:
#ALTAPPS-1030
Checklist
Before Code Review:
Description