Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTAPPS-1026: Shared share streak #737

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Nov 6, 2023

YouTrack Issues:
#ALTAPPS-1026

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • View analytics events are added for new screens;
  • New analytics events are documented;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. ShareStreakDataComponent - contains share streak business logic
  2. CurrentGamificationToolbarDataStateRepository - necessary for correct working of the share streak, we need to know streak state before step completed flow message
  3. Add necessary view actions and analytic events

@ivan-magda ivan-magda added this to the 1.41 milestone Nov 6, 2023
@ivan-magda ivan-magda self-assigned this Nov 6, 2023
@github-actions github-actions bot added the shared Shared module task label Nov 6, 2023
@github-actions github-actions bot added ios iOS module task android Android module task labels Nov 7, 2023
@ivan-magda ivan-magda marked this pull request as ready for review November 8, 2023 10:57
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Nov 8, 2023
@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Nov 9, 2023
@ivan-magda ivan-magda merged commit 9766e74 into develop Nov 9, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1026/shared_share_streak branch November 9, 2023 12:25
vladkash pushed a commit that referenced this pull request Nov 14, 2023
* Set version number to 1.41

* Bump build number

* Shared share streak (#737)

^ALTAPPS-1026

* Bump build number

* iOS share streak (#739)

^ALTAPPS-1027

* Bump build number

* iOS: Fix content mode for images in modals

* iOS: Bump build number

* iOS: LatexView improvements (#741)

* Make ProcessedContentTextView selectable

* Refactor use of LatexView in the app

* iOS: Bump build number

* ALTAPPS-1027: Remove corner radius from shareable images

* iOS: Bump build number

* Android fill in the blanks with select (#743)

^ALTAPPS-1021

* Android: Bump build number

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Aleksandr Zhukov <alexandr.zhukov@hyperskill.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants