Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTAPPS-1013: Shared refactor StepQuizHintsFeature to embeddable feature #733

Merged
merged 7 commits into from
Nov 3, 2023
Merged

ALTAPPS-1013: Shared refactor StepQuizHintsFeature to embeddable feature #733

merged 7 commits into from
Nov 3, 2023

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Nov 1, 2023 •
edited
Loading

YouTrack Issues:
#ALTAPPS-1013, #ALTAPPS-746

Checklist

Before Code Review:

  • Fields "Assignees, Labels, Milestone" are filled in the pull request;
  • All checks have been passed;
  • Changes have been checked locally.

Description

  1. Make StepQuizHintsFeature embeddable feature
  2. Hide hint feedback after it was submited once (ALTAPPS-746)

@ivan-magda ivan-magda added this to the 1.40 milestone Nov 1, 2023
@ivan-magda ivan-magda self-assigned this Nov 1, 2023
@github-actions github-actions bot added shared Shared module task ios iOS module task labels Nov 1, 2023
@github-actions github-actions bot added the android Android module task label Nov 1, 2023
@ivan-magda ivan-magda marked this pull request as ready for review November 1, 2023 14:37
@ivan-magda ivan-magda added the awaiting review Pull Request is awaiting code reviews label Nov 1, 2023
vladkash
vladkash approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@vladkash vladkash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I offer to wait review of @XanderZhu to check android part

iosHyperskillApp/iosHyperskillApp/Sources/Modules/StepQuiz/Views/StepQuizView.swift Outdated Show resolved Hide resolved
...pp/iosHyperskillApp/Sources/Modules/StepQuizSubmodules/StepQuizHints/StepQuizHintsView.swift Show resolved Hide resolved
@ivan-magda
Copy link
Member Author

I offer to wait review of @XanderZhu to check android part

I'll merge this PR, so that QA can test the iOS part, later @XanderZhu will make Android changes if needed

@ivan-magda ivan-magda removed the awaiting review Pull Request is awaiting code reviews label Nov 3, 2023
@ivan-magda ivan-magda merged commit 0a12a1c into develop Nov 3, 2023
9 checks passed
@ivan-magda ivan-magda deleted the feature/ALTAPPS-1013/shared_StepQuizHintsFeature_embeddable branch November 3, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladkash vladkash vladkash approved these changes

Assignees

@ivan-magda ivan-magda

Labels
android Android module task ios iOS module task shared Shared module task
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-magda @vladkash