Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.38 #715

Merged
merged 35 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
3163c54
Shared fill in the blanks with inputs (#711)
XanderZhu Oct 16, 2023
c9a1999
Merge remote-tracking branch 'origin/main' into develop
invalid-email-address Oct 16, 2023
9be3567
Android fix invalid navigation from LimitsBottomSheet (#713)
XanderZhu Oct 17, 2023
4630845
GitHub Actions: Automerge create new release branch if needed (#714)
ivan-magda Oct 17, 2023
fd26d1a
Update setup_new_release_branch.sh
ivan-magda Oct 17, 2023
9853cb7
Update .gitignore
ivan-magda Oct 17, 2023
00535f3
Set version number to 1.38
invalid-email-address Oct 17, 2023
7491c21
Bump build number
invalid-email-address Oct 17, 2023
14bae33
Merge branch 'develop' into feature/fill_blanks_input
ivan-magda Oct 17, 2023
2a53a51
Fix FillBlanks regex
XanderZhu Oct 17, 2023
5d2b19f
Split text items by line break
XanderZhu Oct 18, 2023
65ea64b
Add id to FillBlanksItem
XanderZhu Oct 18, 2023
df8c5a1
Refactor FillBlanksItemMapper
XanderZhu Oct 18, 2023
ebbcdb5
Fix tests
XanderZhu Oct 18, 2023
2b96a60
Fix ktlint
XanderZhu Oct 18, 2023
0914109
GitHub Actions: Bump actions/checkout from 4.1.0 to 4.1.1 (#718)
dependabot[bot] Oct 18, 2023
55a0f90
Merge remote-tracking branch 'origin/develop' into release/1.38
invalid-email-address Oct 18, 2023
bb3b0ba
Bump build number
invalid-email-address Oct 18, 2023
c09d0d9
Replace white-spaces with " " to keep them during html pasing
XanderZhu Oct 19, 2023
18c42dc
Add cache to FillBlanksItemMapper
XanderZhu Oct 20, 2023
1a26191
Shared use new gamification toolbar API (#716)
vladkash Oct 20, 2023
4710b5c
Merge remote-tracking branch 'origin/develop' into release/1.38
ivan-magda Oct 20, 2023
5d7a8d2
Bump build number
ivan-magda Oct 20, 2023
935ad9a
Bump build number
ivan-magda Oct 20, 2023
889ed5a
iOS: Update Devicefile
ivan-magda Oct 23, 2023
7487cea
Merge remote-tracking branch 'origin/develop' into release/1.38
invalid-email-address Oct 23, 2023
504ff1f
iOS: Bump build number
invalid-email-address Oct 23, 2023
e1ddecc
Android fill in the blanks with inputs (#717)
XanderZhu Oct 23, 2023
368d166
iOS fill in the blanks with inputs (#720)
ivan-magda Oct 24, 2023
c94f752
Merge pull request #712 from hyperskill/feature/fill_blanks_input
ivan-magda Oct 24, 2023
5210b2e
Merge remote-tracking branch 'origin/develop' into release/1.38
invalid-email-address Oct 24, 2023
fdcdcfa
Bump build number
invalid-email-address Oct 24, 2023
90a8401
Shared fix error when continue practicing (#719)
vladkash Oct 24, 2023
143bebf
Merge remote-tracking branch 'origin/develop' into release/1.38
invalid-email-address Oct 24, 2023
3b0c87c
Bump build number
invalid-email-address Oct 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/android_beta_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -44,7 +44,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/android_release_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -39,7 +39,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/automerge_into_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1
with:
fetch-depth: 0
token: ${{ secrets.GH_PAT }}
Expand Down Expand Up @@ -84,5 +84,7 @@ jobs:
git push origin release/$next_version_number
else
echo "No existing release/$next_version_number branch found"
echo "Not yet implemented"
echo "Creating new release/$next_version_number branch"
./setup_new_release_branch.sh $next_version_number
fi
4 changes: 2 additions & 2 deletions .github/workflows/build_caches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
uses: ./.github/actions/setup-android
Expand All @@ -55,7 +55,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
timeout-minutes: 5
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -64,7 +64,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
uses: ./.github/actions/setup-android
Expand All @@ -84,7 +84,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup Ruby
uses: ruby/setup-ruby@v1.150.0
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand All @@ -144,7 +144,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand All @@ -167,7 +167,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cleanup_pr_caches.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Cleanup
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Initialize CodeQL
uses: github/codeql-action/init@v2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Detect changes
uses: dorny/paths-filter@v2.11.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh_pages_analytics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
uses: ./.github/actions/setup-android
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ios_beta_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -44,7 +44,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ios_release_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Gradle Wrapper Validation
uses: gradle/wrapper-validation-action@v1.1.0
Expand All @@ -36,7 +36,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios_unit_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1

- name: Setup CI
id: setup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merge_main_into_develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4.1.0
uses: actions/checkout@v4.1.1
with:
fetch-depth: 0
token: ${{ secrets.GH_PAT }}
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ local.properties
*.dSYM

iosHyperskillApp/.build/

iosHyperskillApp/.idea/
iosHyperskillApp/.bundle/
iosHyperskillApp/vendor/

## moko-kswift
iosHyperskillApp/iosHyperskillApp/Sources/Frameworks/sharedSwift/Hyperskill-Mobile_shared.swift
Expand Down
1 change: 1 addition & 0 deletions androidHyperskillApp/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ dependencies {
implementation(libs.android.ui.appcompat)
implementation(libs.android.ui.constraintlayout)
implementation(libs.android.ui.swiperefreshlayout)
implementation(libs.android.ui.flexbox)
implementation(libs.android.ui.core.ktx)
implementation(libs.android.ui.fragment)
implementation(libs.android.ui.fragment.ktx)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,11 @@ class GamificationToolbarDelegate(
if (state is GamificationToolbarFeature.State.Content) {
with(viewBinding.gamificationStreakDurationTextView) {
isVisible = true
val streakDuration = state.streak?.currentStreak ?: 0
text = streakDuration.toString()
val historicalStreak = state.streak?.history?.firstOrNull()
text = state.currentStreak.toString()
setCompoundDrawablesWithIntrinsicBounds(
/* left = */ when {
historicalStreak?.state == StreakState.RECOVERED -> R.drawable.ic_menu_recovered_streak
historicalStreak?.isCompleted == true -> R.drawable.ic_menu_enabled_streak
state.historicalStreak.state == StreakState.RECOVERED -> R.drawable.ic_menu_recovered_streak
state.historicalStreak.isCompleted -> R.drawable.ic_menu_enabled_streak
else -> R.drawable.ic_menu_empty_streak
},
/* top = */ 0,
Expand All @@ -70,12 +68,12 @@ class GamificationToolbarDelegate(
text = state.hypercoinsBalance.toString()
}

state.trackWithProgress.let { trackProgress ->
state.trackProgress.let { trackProgress ->
viewBinding.gamificationTrackProgressLinearLayout.isVisible = trackProgress != null
if (trackProgress != null) {
viewBinding.gamificationTrackProgressView.setProgress(
trackProgress.averageProgress,
trackProgress.trackProgress.isCompleted
trackProgress.isCompleted
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package org.hyperskill.app.android.step_quiz.view.factory
import androidx.fragment.app.Fragment
import org.hyperskill.app.android.step_quiz_choice.view.fragment.ChoiceStepQuizFragment
import org.hyperskill.app.android.step_quiz_code.view.fragment.CodeStepQuizFragment
import org.hyperskill.app.android.step_quiz_fill_blanks.fragment.FillBlanksStepQuizFragment
import org.hyperskill.app.android.step_quiz_matching.view.fragment.MatchingStepQuizFragment
import org.hyperskill.app.android.step_quiz_parsons.view.fragment.ParsonsStepQuizFragment
import org.hyperskill.app.android.step_quiz_sorting.view.fragment.SortingStepQuizFragment
Expand Down Expand Up @@ -42,6 +43,9 @@ object StepQuizFragmentFactory {
BlockName.PARSONS ->
ParsonsStepQuizFragment.newInstance(step, stepRoute)

BlockName.FILL_BLANKS ->
FillBlanksStepQuizFragment.newInstance(step, stepRoute)

else ->
UnsupportedStepQuizFragment.newInstance()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ abstract class DefaultStepQuizFragment :
view?.snackbar(messageRes = org.hyperskill.app.R.string.connection_error)
}
is StepQuizFeature.Action.ViewAction.NavigateTo.Home -> {
requireRouter().backTo(MainScreen())
requireRouter().backTo(MainScreen(Tabs.TRAINING))
mainScreenRouter.switch(Tabs.TRAINING)
}
is StepQuizFeature.Action.ViewAction.NavigateTo.StepScreen -> {
Expand Down
Loading